Skip to content

Reformatted arrays in test files #14310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jorgsowa
Copy link
Contributor

Reformats arrays in test cases using PHP-CS Fixer and following rules:

  • "whitespace_after_comma_in_array": {"ensure_single_space": true},
  • "array_syntax": true,
  • "trailing_comma_in_multiline": true,
  • "method_argument_space": true

Per comment in: #13128 (comment)

@iluuu1994
Copy link
Member

iluuu1994 commented May 23, 2024

I don't think we should do that. In #13128 (comment), I was only referring to the two tests with the deeply nested indentation (which this doesn't seem to address).

@jorgsowa
Copy link
Contributor Author

Sure. I will close it then, although I think some of the test snippets are ugly written and should be reformatted one day.

@jorgsowa jorgsowa closed this May 23, 2024
@iluuu1994
Copy link
Member

Yeah, I don't disagree that the formatting is objectively better. The problem is that it creates more merge conflicts, which sadly is not something that will ever change. This is also why we cannot automate the formatting of the C source code.

@jorgsowa jorgsowa deleted the reformat-arrays-in-standard-math branch August 7, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants