Skip to content

Fix GH-14183: XMLReader::open() can't be overridden #14194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-14183: XMLReader::open() can't be overridden #14194

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

We should only return the override if the internal static method is matched.

@nielsdos
Fix phpGH-14183: XMLReader::open() can't be overridden
5161597 
We should only return the override if the internal static method is matched.
@nielsdos nielsdos linked an issue May 10, 2024 that may be closed by this pull request
XMLReader::open() can't be overridden #14183
Closed
devnexen
devnexen approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsdos nielsdos closed this in 15813d6 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Extension: xmlreader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XMLReader::open() can't be overridden
2 participants
@nielsdos @devnexen