ext/intl: don't always enforce c++17 #14192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the intention of this condition was to check if build is done against icu >= 74 while in practice it's a condition in the form of `test STRING` which in turn is equivalent to `test -n STRING` that checks if passed string is not empty. condition is always satisfied and hence c++17 is also always required. strip `test` part and invoke `pkg-config` directly in condition.
|
Ah sorry, didn't notice #14186. Closing as duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the intention of this condition was to check if build is done against icu >= 74 while in practice it's a condition in the form of
test STRINGwhich in turn is equivalent totest -n STRINGthat checks if passed string is not empty. condition is always satisfied and hence c++17 is also always required.strip
testpart and invokepkg-configdirectly in condition.