Update ext/dom names after policy change #14171
Conversation
| @@ -889,7 +889,7 @@ public function prepend(...$nodes): void {} | |||
| public function replaceChildren(...$nodes): void {} | |||
| } | |||
|
|
|||
| /** @alias DOM\DOMException */ | |||
| /** @alias Dom\DOMException */ | |||
There was a problem hiding this comment.
Is it intentional that the class name follows the discouraged pattern of uppercased abbreviations? Is it for internal consistency with the existing pattern? Personally, I'd vote for going full steam PascalCase. This applies for other abbreviations like HTTP, XML, etc.
There was a problem hiding this comment.
The official name is DOMException: https://webidl.spec.whatwg.org/#idl-DOMException and so this was left alone.
There was a problem hiding this comment.
Ah ok, I see. Then I guess the same applies to all the other names which were left intact.
| @@ -1252,7 +1252,7 @@ public function count(): int {} | |||
| public function getIterator(): \Iterator {} | |||
| } | |||
|
|
|||
| class DTDNamedNodeMap implements \IteratorAggregate, \Countable | |||
| class DtdNamedNodeMap implements \IteratorAggregate, \Countable | |||
There was a problem hiding this comment.
I saw a few properties using discouraged names, like namespaceURI. Can these be renamed?
There was a problem hiding this comment.
Same thing here: namespaceURI is defined per spec with that capitalization.
… classes (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [VarDumper] adapt namespace changes for new DOM extension classes | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT related to php/php-src#14171 Commits ------- 7e25a46 adapt namespace changes for new DOM extension classes
Per https://wiki.php.net/rfc/class-naming-acronyms, change the acronyms in ext/dom's new PHP 8.4 classes.