-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update CODING_STANDARDS for the acronym casing RFC #14169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the ideal person to reviewing policy text, but I think this is good.
I think this looks reasonable aside from the one formatting note. Once it's merged I'll see about getting PER-CS updated to match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Larry's remark LGTM.
Maybe @derickr wants to review this too?
Co-authored-by: Larry Garfield <larry@garfieldtech.com>
The adjustments I made were directly taken from the RFC text itself (i.e. the phrasing was voted on). I just wanted the second pair of eyes to check whether I professionally copy and pasted the stuff and whether formatting is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we don't have this in two places any more. I would be in favour of removing this now, and pointing to https://github.com/php/policies/blob/main/coding-standards-and-naming.rst
@derickr I agree, but the CODING_STANDARDS.md contains more instructions than the coding-standards-and-naming.rst. An experienced technical writer would need to correctly merge those. I'm not the right person for that. |
see https://wiki.php.net/rfc/class-naming-acronyms
/cc @Crell