Skip to content

Update CODING_STANDARDS for the acronym casing RFC #14169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented May 7, 2024

@TimWolla TimWolla requested review from nielsdos and Girgias May 7, 2024 18:50
@TimWolla TimWolla added the RFC label May 7, 2024
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the ideal person to reviewing policy text, but I think this is good.

@Crell
Copy link
Contributor

Crell commented May 7, 2024

I think this looks reasonable aside from the one formatting note. Once it's merged I'll see about getting PER-CS updated to match.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Larry's remark LGTM.

Maybe @derickr wants to review this too?

Co-authored-by: Larry Garfield <larry@garfieldtech.com>
@TimWolla TimWolla merged commit 48971af into php:master May 8, 2024
1 of 4 checks passed
@TimWolla TimWolla deleted the acronym-casing-policy branch May 8, 2024 18:35
@TimWolla
Copy link
Member Author

TimWolla commented May 8, 2024

Maybe derickr wants to review this too?

The adjustments I made were directly taken from the RFC text itself (i.e. the phrasing was voted on). I just wanted the second pair of eyes to check whether I professionally copy and pasted the stuff and whether formatting is good.

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we don't have this in two places any more. I would be in favour of removing this now, and pointing to https://github.com/php/policies/blob/main/coding-standards-and-naming.rst

@TimWolla
Copy link
Member Author

I would be in favour of removing this now, and pointing to https://github.com/php/policies/blob/main/coding-standards-and-naming.rst

@derickr I agree, but the CODING_STANDARDS.md contains more instructions than the coding-standards-and-naming.rst. An experienced technical writer would need to correctly merge those. I'm not the right person for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants