CI: Do not save the ccache for PRs #14168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
May 7, 2024
| @@ -72,6 +72,7 @@ jobs: | |||
| # job id, not the job name) | |||
| key: "LINUX_X64_${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}-${{hashFiles('main/php_version.h')}}" | |||
| append-timestamp: false | |||
| save: ${{ github.event_name != 'pull_request' }} | |||
There was a problem hiding this comment.
This should be added to all the usages of hendrikmuhs/ccache-action in this file, I believe.
There was a problem hiding this comment.
Good catch, thanks. I've added it after waiting for the initial build to pass to verify that my YAML programming worked fine.
Will merge once CI is green for PHP 8.2 and after making a final verification of the log output.
There was a problem hiding this comment.
Great! Also note that another instance exists on PHP 8.3+ (the benchmarking job).
There was a problem hiding this comment.
Thanks for the heads up. For completeness I've also added it to the Nightly job, even though it does not run for PRs. Commit: 402f3a9
TimWolla
force-pushed
the
ccache-pr-no-save
branch
from
096adfb to
f072c3b
Compare
TimWolla
added a commit
that referenced
this pull request
May 7, 2024
* PHP-8.2: CI: Do not save the ccache for PRs (#14168)
TimWolla
added a commit
that referenced
this pull request
May 7, 2024
TimWolla
added a commit
that referenced
this pull request
May 7, 2024
* PHP-8.3: CI: Do not save the ccache for PRs (8.3+) CI: Do not save the ccache for PRs (#14168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14155