Skip to content

Cast the parameter type of arm's BLOCKCONV_LOAD #14151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented May 6, 2024

configure:

./configure --enable-debug --disable-all CFLAGS='-ffp-contract=off -fsanitize=undefined,address -fno-sanitize-recover -DZEND_TRACK_ARENA_ALLOC' LDFLAGS='-fsanitize=undefined,address'

master: OK
8.3: OK

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is right, but should go into PHP 8.3 and master.
Did you validate locally using UBSAN that the problem no longer reproduces?

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
@SakiTakamachi
Copy link
Member Author

I'll reflect your suggestion and check again with 8.3 and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants