Skip to content

Add missing COMPILE_IGNORE_OTHER_FILES check for static calls #13986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Apr 17, 2024

Reproducer:

// a.php
class C {
    public static function test($a, $b) {
        echo "a: $a, b: $b";
    }
}

require __DIR__ . '/b.php';

// b.php
C::test(a: 'a', b: 'b');

php -d opcache.enable=1 -S 127.0.0.1:8000 a.php

Running the example, and then swapping the parameters of test() will result in the wrong output until the server is restarted.

@iluuu1994 iluuu1994 force-pushed the fix-static-call-ignore-other-files-check branch from 61f893d to 11d1f23 Compare April 17, 2024 18:40
@iluuu1994 iluuu1994 closed this in 1acd7a0 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants