-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ext/pcntl: pcntl_getqos_class/pcntl_setqos_class addition. #13945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1003,3 +1003,17 @@ function pcntl_setcpuaffinity(?int $process_id = null, array $cpu_ids = []): boo | |
#ifdef HAVE_SCHED_GETCPU | ||
function pcntl_getcpu(): int {} | ||
#endif | ||
|
||
#ifdef HAVE_PTHREAD_SET_QOS_CLASS_SELF_NP | ||
enum QosClass | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be named |
||
{ | ||
case UserInteractive; | ||
case UserInitiated; | ||
case Default; | ||
case Utility; | ||
case Background; | ||
} | ||
|
||
function pcntl_getqos_class(): QosClass {} | ||
function pcntl_setqos_class(QosClass $qos_class = QosClass::Default): void {} | ||
#endif |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--TEST-- | ||
pcntl_getqos_class()/pcntl_setqos_class() | ||
--EXTENSIONS-- | ||
pcntl | ||
--SKIPIF-- | ||
<?php | ||
if (!function_exists("pcntl_getqos_class")) die("skip pcntl_getqos_class() is not available"); | ||
if (getenv('SKIP_REPEAT')) die("skip Not repeatable"); | ||
?> | ||
--FILE-- | ||
<?php | ||
pcntl_setqos_class(QosClass::Default); | ||
var_dump(QosClass::Default === pcntl_getqos_class()); | ||
pcntl_setqos_class(QosClass::Background); | ||
var_dump(QosClass::Background == pcntl_getqos_class()); | ||
?> | ||
--EXPECT-- | ||
bool(true) | ||
bool(true) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If macOS ever introduces more qos types, then the fact this is uninitialized but used below will be UB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite apple has very little incentive to add more level of service, default is handled below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, you are right. I missed the
default
.