ext/fileinfo/tests/bug78987.phpt: increase a memory limit #13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test performs a few checks to ensure that "not too much" memory is used while fileinfo is detecting encodings. It is however platform specific, and memory usage varies across hosts and as libmagic changes. Recently a Gentoo user reported a failure in this test at, https://bugs.gentoo.org/927461 on a big-endian PPC64 machine with output, ---- EXPECTED OUTPUT 131072 => ok 262144 => ok 524288 => ok 1048576 => ok 2097152 => ok 4194304 => ok 8388608 => ok 16777216 => ok ---- ACTUAL OUTPUT 131072 => 10092544 262144 => 10092544 524288 => 12189696 1048576 => 12189696 2097152 => 14352384 4194304 => 18612224 8388608 => 24903680 16777216 => 37486592 ---- FAILED Those numbers are with 8.3.4 and therefore missing commit b7c5813 which also raises the limits. Checking the "actual" numbers above against the current values, we see that the limit for 524288 would need to be bumped to 12189696 to allow this test to pass. Since that seems reasonable, that's what this commit does. Closes phpGH-13795
nielsdos
approved these changes
Apr 11, 2024
|
I think so. The issue exists in 8.3, and the patch should apply cleanly. The issue was also observed in 8.2, but this patch alone won't fix it. |
Okay, thanks. I'll cherry-pick this into PHP-8.3 and up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test performs a few checks to ensure that "not too much" memory is used while fileinfo is detecting encodings. It is however platform specific, and memory usage varies across hosts and as libmagic changes.
Recently a Gentoo user reported a failure in this test at https://bugs.gentoo.org/927461 on a big-endian PPC64 machine with output,
Those numbers are with 8.3.4 and therefore missing commit b7c5813c which also raises the limits. Checking the "actual" numbers above against the current values, we see that the limit for 524288 would need to be bumped to 12189696 to allow this test to pass. Since that seems reasonable, that's what this commit does.
Closes GH-13795