Skip to content

Fix #13865 Improve parameter and return value related deprecation mesages #13913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Apr 7, 2024

At last, I added the function/method name to some compile-time deprecation messages which are related to parameters/return values. Consistent with the other similar error messages, I included the function/method name at the start of the message.

Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but maybe should wait for others reviews.

@kocsismate kocsismate requested a review from Girgias April 8, 2024 06:11
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

@kocsismate kocsismate merged commit 2079da0 into php:master Apr 8, 2024
@kocsismate kocsismate deleted the param-deprecation-error-message branch April 8, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants