ext/pcntl: cpu affinity api introduction. #13893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
pcntl_cpuaffinity
branch
6 times, most recently
from
cc65a36 to
fa2077b
Compare
For now, working on Linux, FreeBSD >= 13.x and DragonFlyBSD. Handy wrapper to assign an array of cpu ids or to retrieve the cpu ids assigned to a given process. pcntl_setaffinity inserts valid unique cpu ids (within the range of available cpus).
devnexen
force-pushed
the
pcntl_cpuaffinity
branch
from
fa2077b to
5f7e7ba
Compare
nielsdos
requested changes
Apr 6, 2024
devnexen
force-pushed
the
pcntl_cpuaffinity
branch
6 times, most recently
from
afed2bf to
7b9d1d9
Compare
nielsdos
requested changes
Apr 6, 2024
devnexen
force-pushed
the
pcntl_cpuaffinity
branch
from
7b9d1d9 to
d1bce65
Compare
nielsdos
requested changes
Apr 6, 2024
nielsdos
requested changes
Apr 6, 2024
devnexen
force-pushed
the
pcntl_cpuaffinity
branch
from
6cd94c1 to
b7e805a
Compare
nielsdos
reviewed
Apr 6, 2024
ext/pcntl/pcntl.c
Outdated
| if (Z_TYPE_P(ncpu) == IS_STRING) { | ||
| zend_ulong tmp; | ||
| if (!ZEND_HANDLE_NUMERIC(Z_STR_P(ncpu), tmp)) { | ||
| zend_argument_value_error(2, "cpu id invalid type (%s)", ZSTR_VAL(Z_STR_P(ncpu))); |
There was a problem hiding this comment.
Perhaps the wording could be a bit better because now it sounds like the type is the value of the string, but this works too and does not block the PR.
There was a problem hiding this comment.
Thanks for your review !
addressing other remarks.
devnexen
force-pushed
the
pcntl_cpuaffinity
branch
from
b7e805a to
866fbc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, working on Linux, FreeBSD >= 13.x and DragonFlyBSD. Handy wrapper to assign an array of cpu ids or to retrieve the cpu ids assigned to a given process.
pcntl_setaffinity inserts valid unique cpu ids (within the range of available
cpus).