Double speed of PBKDF2 #1387
Closed
Double speed of PBKDF2 #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By hoisting the processing of inner/outer key blocks
out of the inner loop, we calculate PBKDF2 with approx
half the hash compression function applications.
Speed comparison:
test.php is:
<?php hash_pbkdf2('sha1', 'password', 'saltsalt', 1 << 24, 0); ?>
$ TIME='%U' time php test.php
24.56
$ TIME='%U' time ./sapi/cli/php test.php
12.82
|
Since this has generated no interest, or reviews, and since it targets a security fix only branch of PHP, I'm closing this PR. Please take this action as encouragement to open a PR against a supported branch of PHP, in addition, please start an internals discussion in order to attract someone to review the code. |
|
@paragonie-scott what do you think about the propsed changes? |
This was referenced Sep 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By hoisting the processing of inner/outer key blocks
out of the inner loop, we calculate PBKDF2 with approx
half the hash compression function applications.
Speed comparison:
test.php is:
$ TIME='%U' time php test.php
24.56
$ TIME='%U' time ./sapi/cli/php test.php
12.82