Fix gcc-14 Wcalloc-transposed-args warnings #13818
Conversation
gcc-14 and later warns of inverted arguments in calloc or calloc-like __alloc_size__ annotated functions.
|
Can you please target the PR to PHP-8.3. |
Mine to share why ? despite the warnings the resulting allocations will have the same size..this is just to shut up the compiler..all of this assuming all the wrappers used by ecalloc multiply both values..(which seems to be the case on a quick glance) |
|
Warnings tells what something is wrong. Actually, they caught bugs that might cause different alignment of allocated memory. |
crrodriguez
requested review from
kocsismate,
arnaud-lb,
NattyNarwhal,
alexdowad,
nielsdos,
devnexen,
Girgias,
derickr,
adoy and
TimWolla
as code owners
|
@crrodriguez Looks like something went wrong when changing branches, you should typically rebase instead of merge to fix up your branch after changing the base branch. |
Yes, please if you can. |
|
Merged manually, thanks for the patch! |
gcc-14 and later warns of inverted arguments in calloc or calloc-like __alloc_size__ annotated functions. Closes phpGH-13818.
gcc-14 and later warns of inverted arguments in calloc or calloc-like alloc_size annotated functions.