Skip to content

Remove obsolete Makefile .NOEXPORT target #13734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

petk
Copy link
Member

@petk petk commented Mar 16, 2024

This was once used on GNU Make from versions 3.59 to 3.63 (released in 1994) to not export all variables, otherwise a system limit may be exceeded. This was the case for the obsolete UNIX System V (SysV) and is on current systems not applicable anymore, with such target ignored.

P.S.: I find these museum features really fascinating because you can learn really a lot but it's also kind of redundant in today's code and causes only bloat since there isn't any documentation anymore about this.

This was once used on GNU Make from versions 3.59 to 3.63 (released in
1994) to not export all variables, otherwise a system limit may be
exceeded. This was the case for the obsolete UNIX System V (SysV) and is
on current systems not applicable anymore, with such target ignored.
@petk
Copy link
Member Author

petk commented May 29, 2024

I'm not sure anyone is seeing comments on these old PRs, but I'll merge this one in the following days. Perhaps cc-ing @devnexen

It has been rechecked.

@petk petk merged commit d8da8d8 into php:master May 30, 2024
@petk petk deleted the patch-gnu-make-noexport branch May 30, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants