Skip to content

Check asm goto support with AC_LINK_IFELSE #13716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

petk
Copy link
Member

@petk petk commented Mar 14, 2024

The 'asm goto' support is properly recognized by a simpler linking check instead of a run check for easier cross-compilation. The compile only check (AC_COMPILE_IFELSE) might produce false positives results with certain compiler options.

The '__asm__ goto' support is properly recognized by a simpler linking
check instead of a run check for easier cross-compilation. The
compile only check (AC_COMPILE_IFELSE) might produce false positives
results with certain compiler options.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, I do not foresee any side effect but I m glad it is on master :)

@petk
Copy link
Member Author

petk commented Mar 14, 2024

It should work ok, no worries. It was tested on various systems and double checked. :)

@petk petk merged commit d2eb3e5 into php:master Mar 15, 2024
@petk petk deleted the patch-asm-goto branch March 15, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants