Skip to content

zend_test fix copy_file_range test for linux 32 bits #13708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

zend_test fix copy_file_range test for linux 32 bits #13708

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

No description provided.

@petk
Copy link
Member

petk commented Mar 14, 2024

What about setting the #define _FILE_OFFSET_BITS 64 and use off_t everywhere in the php-src? This would be too dangerous? Because there are more of these bugs on Alpine and Musl.

@devnexen
Copy link
Member Author

Maybe, but I m not sure about this kind of change on a stable branch.

@nielsdos
Copy link
Member

I wouldn't do that on a stable branch.

@petk
Copy link
Member

petk commented Mar 14, 2024

ok

@devnexen devnexen requested a review from nielsdos March 14, 2024 08:39
@nielsdos
Copy link
Member

I'll check tonight

nielsdos
nielsdos approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to build fine on 32-bit.

@devnexen devnexen closed this in db1f7b1 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @petk @nielsdos