Skip to content

Fix GH-13688: Test curl_basic_008 can fail #13693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix GH-13688: Test curl_basic_008 can fail #13693

merged 1 commit into from
Jul 4, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Mar 12, 2024 •
edited
Loading

I'd say: just point it to a domain PHP controls and we should be fine?

@nielsdos nielsdos requested a review from adoy as a code owner March 12, 2024 20:48
@nielsdos nielsdos linked an issue Mar 12, 2024 that may be closed by this pull request
Test curl_basic_008 can fail #13688
Closed
@nielsdos nielsdos mentioned this pull request Mar 12, 2024
Closed
@Ayesh
Copy link
Member

Ayesh commented Mar 13, 2024

Apparently .invalid is a reserved TLD that's supposed to be never assigned.

@nielsdos
Copy link
Member Author

nielsdos commented Jul 4, 2024

Thanks @Ayesh let's use that then!

@nielsdos
Fix phpGH-13688: Test curl_basic_008 can fail
08ab55a 
.invalid is a reserved TLD that should never be caught.
@nielsdos nielsdos merged commit 39ed999 into php:PHP-8.2 Jul 4, 2024
9 checks passed
nielsdos added a commit that referenced this pull request Jul 4, 2024
@nielsdos
Merge branch 'PHP-8.2' into PHP-8.3
9e47677 
* PHP-8.2:
  Fix GH-13688: Test curl_basic_008 can fail (#13693)
nielsdos added a commit that referenced this pull request Jul 4, 2024
@nielsdos
Merge branch 'PHP-8.3'
bcfdf10 
* PHP-8.3:
  Fix GH-13688: Test curl_basic_008 can fail (#13693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Labels
Extension: curl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test curl_basic_008 can fail
2 participants
@nielsdos @Ayesh