Skip to content

Find AppArmor library with pkgconf #13644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Find AppArmor library with pkgconf #13644

merged 1 commit into from
Mar 10, 2024

Conversation

petk
Copy link
Member

@petk petk commented Mar 9, 2024

The AppArmor library has had pkg-config/pkgconf integration since its early versions (2012), when it was integrated from the libaalogparse into the AppArmor project. To ease this change, the check without pkgconf is executed in case the libapparmor.pc file is not found on the system.

A sanity check also covers cases where the library path is overriden:
/configure --enable-fpm --with-fpm-apparmor
APPARMOR_CFLAGS=-I/path/to/libapparmor
APPARMOR_LIBS="-L/path/to/libapparmor -lapparmor"

This also removes the redundant symbol HAVE_SYS_APPARMOR_H since the sys/apparmor.h header is considered a required part of the AppArmor library package.

The AppArmor library has had pkg-config/pkgconf integration since its
early versions (2012), when it was integrated from the libaalogparse
into the AppArmor project. To ease this change, the check without
pkgconf is executed in case the libapparmor.pc file is not found on the
system.

A sanity check also covers cases where the library path is overriden:
  /configure --enable-fpm --with-fpm-apparmor \
    APPARMOR_CFLAGS=-I/path/to/libapparmor \
    APPARMOR_LIBS="-L/path/to/libapparmor -lapparmor"

This also removes the redundant symbol HAVE_SYS_APPARMOR_H since the
sys/apparmor.h header is considered a required part of the AppArmor
library package.
@petk petk merged commit 816f6a5 into php:master Mar 10, 2024
@petk petk deleted the patch-apparmor branch March 10, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants