Skip to content

Implement GH-13609: Dump wrapped object in WeakReference class #13621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2024
Merged

Implement GH-13609: Dump wrapped object in WeakReference class #13621

merged 2 commits into from
Mar 8, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Mar 7, 2024

I chose "object" as that's also the argument name in WeakReference::create.

@nielsdos nielsdos requested a review from iluuu1994 as a code owner March 7, 2024 20:20
@nielsdos nielsdos linked an issue Mar 7, 2024 that may be closed by this pull request
Dump wrapped object in WeakReference class #13609
Closed
iluuu1994
iluuu1994 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nielsdos!

@nielsdos nielsdos merged commit d6d3370 into php:master Mar 8, 2024
nielsdos added a commit to nielsdos/php-src that referenced this pull request Mar 10, 2024
@nielsdos
Revert "Implement phpGH-13609: Dump wrapped object in WeakReference c…
391dbb9 
…lass (php#13621)"

This reverts commit d6d3370.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dump wrapped object in WeakReference class
2 participants
@nielsdos @iluuu1994