*[Sessions]: Now session is accessible if process is ran by root. #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please leave this one, and close others. we can merge it downwards if it is necessary. |
|
Done. Weird, that CI build has failed for this Pull Request, while successfully passed for one of the closed ones. |
| accessed by backend with root permissions to execute some system tasks. | ||
|
|
||
| */ | ||
| if (fstat(data->fd, &sbuf) || (sbuf.st_uid != 0 && sbuf.st_uid != getuid() && sbuf.st_uid != geteuid() && getuid() != 0)) { |
There was a problem hiding this comment.
Please use portable zend_fstat in master.
Thanks.
Merging upstream
…ing bug: https://bugs.php.net/bug.php?id=69582 *[Sessions]: Replaced fstat with zend_fstat
|
Done that. |
php-pulls
pushed a commit
that referenced
this pull request
Jan 6, 2017
* pull-request/1360: Fixed bug #69582 session not readable by root in CLI news entry for PR #1360
|
Thanks :) |
|
@krakjoe Thanks for merging. Is there are any plans for merging it downstream, like at least 5.6? |
|
It is present in all branches in supported release cycle. 5.6 is in security fix only cycle and so should not be having fixes like this merged, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug: https://bugs.php.net/bug.php?id=69582
Use case: session is initiated by Apache with non-root permissions. Later on, session could be accessed by backend process, which runs under root, but needs to communicate with same session data as Apache process.
Didn't work before this commit: session file is owned by non-root, process owner != file owner, so this triggered file handle closure.