Skip to content

ext/xmlreader: Add class constant types to stub #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,9 @@ PHP 8.4 UPGRADE NOTES
- Sqlite:
. The class constants are typed now.

- XMLReader:
. The class constants are typed now.

- XSL:
. The typed properties XSLTProcessor::$cloneDocument and
XSLTProcessor::$doXInclude are now declared.
Expand Down
66 changes: 22 additions & 44 deletions ext/xmlreader/php_xmlreader.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,118 +7,96 @@ class XMLReader
/* Constants for NodeType - cannot define common types to share with dom as there are differences in these types */

/**
* @var int
* @cvalue XML_READER_TYPE_NONE
*/
public const NONE = UNKNOWN;
public const int NONE = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_ELEMENT
*/
public const ELEMENT = UNKNOWN;
public const int ELEMENT = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_ATTRIBUTE
*/
public const ATTRIBUTE = UNKNOWN;
public const int ATTRIBUTE = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_TEXT
*/
public const TEXT = UNKNOWN;
public const int TEXT = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_CDATA
*/
public const CDATA = UNKNOWN;
public const int CDATA = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_ENTITY_REFERENCE
*/
public const ENTITY_REF = UNKNOWN;
public const int ENTITY_REF = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_ENTITY
*/
public const ENTITY = UNKNOWN;
public const int ENTITY = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_PROCESSING_INSTRUCTION
*/
public const PI = UNKNOWN;
public const int PI = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_COMMENT
*/
public const COMMENT = UNKNOWN;
public const int COMMENT = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_DOCUMENT
*/
public const DOC = UNKNOWN;
public const int DOC = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_DOCUMENT_TYPE
*/
public const DOC_TYPE = UNKNOWN;
public const int DOC_TYPE = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_DOCUMENT_FRAGMENT
*/
public const DOC_FRAGMENT = UNKNOWN;
public const int DOC_FRAGMENT = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_NOTATION
*/
public const NOTATION = UNKNOWN;
public const int NOTATION = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_WHITESPACE
*/
public const WHITESPACE = UNKNOWN;
public const int WHITESPACE = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_SIGNIFICANT_WHITESPACE
*/
public const SIGNIFICANT_WHITESPACE = UNKNOWN;
public const int SIGNIFICANT_WHITESPACE = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_END_ELEMENT
*/
public const END_ELEMENT = UNKNOWN;
public const int END_ELEMENT = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_END_ENTITY
*/
public const END_ENTITY = UNKNOWN;
public const int END_ENTITY = UNKNOWN;
/**
* @var int
* @cvalue XML_READER_TYPE_XML_DECLARATION
*/
public const XML_DECLARATION = UNKNOWN;
public const int XML_DECLARATION = UNKNOWN;

/* Constants for Parser options */

/**
* @var int
* @cvalue XML_PARSER_LOADDTD
*/
public const LOADDTD = UNKNOWN;
public const int LOADDTD = UNKNOWN;
/**
* @var int
* @cvalue XML_PARSER_DEFAULTATTRS
*/
public const DEFAULTATTRS = UNKNOWN;
public const int DEFAULTATTRS = UNKNOWN;
/**
* @var int
* @cvalue XML_PARSER_VALIDATE
*/
public const VALIDATE = UNKNOWN;
public const int VALIDATE = UNKNOWN;
/**
* @var int
* @cvalue XML_PARSER_SUBST_ENTITIES
*/
public const SUBST_ENTITIES = UNKNOWN;
public const int SUBST_ENTITIES = UNKNOWN;


public int $attributeCount;
Expand Down
46 changes: 23 additions & 23 deletions ext/xmlreader/php_xmlreader_arginfo.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.