zend call stack adjust case for freebsd to calculate the guard size. #13586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was not wrong but there is a sysctl oid storing the number of guard pages, which is 1 by default but is modifiable at runtime.
arnaud-lb
reviewed
Mar 4, 2024
Zend/zend_call_stack.c
Outdated
| if (sysctlbyname("security.bsd.stack_guard_page", &tmpguards, &len, NULL, 0) != 0) { | ||
| return false; | ||
| } | ||
| numguards = tmpguards; |
There was a problem hiding this comment.
Is this thread safe? Are you relying on the fact that its a word sized write?
arnaud-lb
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was not wrong but there is a sysctl oid storing the number of guard pages, which is 1 by default but is modifiable at runtime.