Skip to content

[Test libmysqlclient] remove REPORT_EXIT_STATUS=no #13416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Test libmysqlclient] remove REPORT_EXIT_STATUS=no #13416

wants to merge 1 commit into from

Conversation

SakiTakamachi
Copy link
Member

No description provided.

@SakiTakamachi
Copy link
Member Author

@iluuu1994
Is it okay to remove this?

@SakiTakamachi SakiTakamachi changed the base branch from master to PHP-8.2 February 17, 2024 10:24
@iluuu1994
Copy link
Member

Yes, we should remove this. However, note that we have failing tests:
https://github.com/php/php-src/actions/runs/7938287164/job/21676925975
I'm not sure since when this is failing...

@SakiTakamachi
Copy link
Member Author

@iluuu1994

Yeah, I noticed this because the test was failing but the CI was passing.

It's been failing since I cleaned up my tests 3 months ago. Fortunately, there's no bug in pdo itself, just a test that's wrong.

With this PR, should I fix the tests together? It'll probably be done soon.

@iluuu1994
Copy link
Member

With this PR, should I fix the tests together? It'll probably be done soon.

Yes, please fix them together or fix them before removing this flag.

@SakiTakamachi
Copy link
Member Author

It's been failing since I cleaned up my tests 3 months ago

I look closely, it's a little different. Both are failing even before my cleanup. One has been failing, probably since the time the test was added (7 months ago).

I'll fix it anyway.

@SakiTakamachi SakiTakamachi mentioned this pull request Feb 18, 2024
Merged
@SakiTakamachi
Copy link
Member Author

I made a separate PR for the tests that only fail on master.
#13424

The other one is included in this PR.

@SakiTakamachi
Copy link
Member Author

It might be useful to be able to run tests selectively, with commit messages like [with libmysql]...

@kamil-tekiela
Copy link
Member

Can you rebase now, please?

@SakiTakamachi
Copy link
Member Author

If you approve, I can do it myself! (I have commit rights since last month)

@SakiTakamachi SakiTakamachi force-pushed the test/github_acions_libmysqlclient branch from 681827c to 957ab4a Compare February 18, 2024 12:39
@SakiTakamachi
Copy link
Member Author

It would be helpful if someone could look at this.

@SakiTakamachi
Copy link
Member Author

I forgot to write "closes"

@SakiTakamachi SakiTakamachi deleted the test/github_acions_libmysqlclient branch February 28, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla is a code owner

Assignees
No one assigned
Labels
Extension: pdo_mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SakiTakamachi @iluuu1994 @kamil-tekiela