Skip to content

Change long2ip return type #13395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 16, 2024
Merged

Change long2ip return type #13395

merged 5 commits into from
Feb 16, 2024

Conversation

jorgsowa
Copy link
Contributor

The function inet_ntop cannot return false in the current usage, as was described https://github.com/vimeo/psalm/pull/9537#discussion_r1140799451.

@jorgsowa jorgsowa mentioned this pull request Feb 14, 2024
Closed
@jorgsowa jorgsowa marked this pull request as draft February 15, 2024 10:48
@devnexen
Copy link
Member

test failing on windows seem related

@nielsdos
Copy link
Member

nielsdos commented Feb 15, 2024 •
edited
Loading

It fails because the assertion may be deleted and so the function call too.
Split the call from the assertion: store the result of the call in a variable, and do the assertion on the variable

@jorgsowa jorgsowa marked this pull request as ready for review February 15, 2024 21:43
devnexen
devnexen reviewed Feb 15, 2024
View reviewed changes
@devnexen
Copy link
Member

Look ok otherwise.

@devnexen
Copy link
Member

Would it be possible to squash your commits ?

@kocsismate
Copy link
Member

@devnexen It is possible to squash the commits on the GitHub UI. Since the MR looks good to me as well, I'll do it.

@kocsismate kocsismate merged commit e7b1f2a into php:master Feb 16, 2024
@jorgsowa
Copy link
Contributor Author

Thanks!

@jorgsowa jorgsowa mentioned this pull request Feb 16, 2024
Merged
@kocsismate kocsismate mentioned this pull request Mar 20, 2024
Merged
@jorgsowa jorgsowa deleted the change_long2ip_return_type branch August 7, 2024 22:24
@cedric-anne cedric-anne mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen left review comments

@nielsdos nielsdos nielsdos left review comments

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Optimizer Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorgsowa @devnexen @nielsdos @kocsismate