Simplify strcasestr check in fileinfo #13365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strcasestr is not present on Windows and on Solaris 10 until Solaris 11 implementation in string.h. At this point strcasestr is not used in the bundled libmagic (file) library due to patch removing the strcasestr usage in file.c, however future libmagic version bump might need it again. This simplifies the strcasestr check if available on the system without running the test code and avoiding the unknown issue when cross-compiling. If found, the HAVE_STRCASESTR is defined, otherwise the strcasestr.c is added to the build sources.
devnexen
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strcasestr is not present on Windows and on Solaris 10 until Solaris 11 implementation in string.h.
At this point strcasestr is not used in the bundled libmagic (file) library due to patch removing the strcasestr usage in file.c, however future libmagic version bump might need it again. This simplifies the strcasestr check if available on the system without running the test code and avoiding the unknown issue when cross-compiling. If found, the HAVE_STRCASESTR is defined, otherwise the strcasestr.c is added to the build sources.