Fix undefined symbol pthread_attr_get_np on Solaris #13358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solaris doesn't have pthread_attr_get_np(). Checked on Oracle Solaris 11.4.
Solaris :-), are the Zend stack_limit tests passing for you ? |
|
Zend directory tests pass.
…On Thu, 8 Feb 2024, 21:30 David CARLIER, ***@***.***> wrote:
Solaris doesn't have pthread_attr_get_np().
Checked on Oracle Solaris 11.4.
...php-src/Zend/zend_call_stack.c:674:17: warning: implicit declaration of function ‘pthread_attr_get_np’; did you mean ‘pthread_attr_getname_np’? [-Wimplicit-function-declaration]
674 | error = pthread_attr_get_np(pthread_self(), &attr);
| ^~~~~~~~~~~~~~~~~~~
| pthread_attr_getname_np
Undefined first referenced
symbol in file
pthread_attr_get_np Zend/zend_call_stack.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
Solaris :-), do the Zend stack_limit tests pass for you ?
—
Reply to this email directly, view it on GitHub
<#13358 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMKBOOI2623376ZQXGZEE3YSUYVJAVCNFSM6AAAAABDALNPKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUHA4DMNRVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
devnexen
approved these changes
Feb 8, 2024
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Feb 10, 2024
for threaded context, it solely uses a new api only available on illumos. Here using a common older api to get the stack info for the current thread. while at it, completing stack_limit_010 test for these platforms.
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Feb 16, 2024
for threaded context, it solely uses a new api only available on illumos. Here using a common older api to get the stack info for the current thread. while at it, completing stack_limit_010 test for these platforms.
devnexen
added a commit
that referenced
this pull request
Feb 16, 2024
for threaded context, it solely uses a new api only available on illumos. Here using a common older api to get the stack info for the current thread. while at it, completing stack_limit_010 test for these platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solaris doesn't have pthread_attr_get_np().
Checked on Oracle Solaris 11.4.