Skip to content

dereference values in parameters in all functions where it was missing #13355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

dereference values in parameters in all functions where it was missing #13355

wants to merge 1 commit into from

Conversation

georgebarbarosie
Copy link
Contributor

Fixes issue #13354

@devnexen
Copy link
Member

devnexen commented Feb 8, 2024

thanks. Now you need to add a test :-)

@georgebarbarosie
Copy link
Contributor Author

Apologies, I'm a first time contributor. I'll figure out how to write the test.

@devnexen
Copy link
Member

devnexen commented Feb 8, 2024

Could you do the following please ?

  • Renaming bug13354.phpt to gh13354.phpt.
  • Changing its reference from Bug #13354 to something like GH-13354.
  • Squashing all your commits into one.
    Sorry I forgot to tell you, you could not really know.

devnexen
devnexen approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I just need to pay attention with your test and the master branch but you do not need to worry :)

@devnexen devnexen closed this in 452e008 Feb 8, 2024
devnexen added a commit that referenced this pull request Feb 8, 2024
@devnexen
GH-13355 fix new pgsql test
c5fbcfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Extension: pgsql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgebarbarosie @devnexen