-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Move constants from dir.c to stub file #13312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very nice catch, I'm not sure why I didn't put these constants into stub! Thanks for the PR! |
…ns into the stub file
There are a few more of these that I think could be moved to a stub file. I'll open a PR for these today or tomorrow. I used the below command to list all the remaining constants not registered in stub files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I had only 2 small nits. I'll merge the PR once these are resolved ) Thanks for your work!
Moves registering some constant from
dir.c
to its corresponding stub file with four constant registrations remaining indir.c
.@kocsismate pinging you as this is a stub file change as well.