Zend,fibers: Ensure fiber stack is not backed by THP. #13306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ending with fiber stack mapped in hugepages will affect performance badly. Until < Linux 6.8-rc2 MAP_STACK was a noop, now it implies no THP, older releases need madvise.
crrodriguez
force-pushed
the
fiber_stack_no-THP
branch
from
8b8152b to
67d2180
Compare
|
Changed to use madvise instead because MAP_GROWSDOWN has additional semantic changes not just THP-disable the mapping, |
How bad that is w/o the changes ? |
Im sorry but producing a test case would be quite involved..bad enough to get all MAP_STACK mappings on the whole system not to use THP. |
|
Fair enough :-) makes sense to me, maybe @nielsdos might have a look. |
nielsdos
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ending with fiber stack mapped in hugepages will affect performance badly.
Until < Linux 6.8-rc2 MAP_STACK was a noop, now it implies no THP, older releases need madvise.