Skip to content

Fix "warning: conflicting types for ‘zend_multibyte_set_script_encoding’ due to enum/integer mismatch;" #13227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

youkidearitai
Copy link
Contributor

Related: #13122

I found return type mismatch and displays warning when GCC 13 on Ubuntu 23.10.

/home/tekimen.linux/src/youkidearitai_php-src/Zend/zend_multibyte.c:173:22: warning: conflicting types for ‘zend_multibyte_set_script_encoding’ due to enum/integer mismatch; have ‘zend_result(const zend_encoding **, size_t)’ {aka ‘ZEND_RESULT_CODE(const struct _zend_encoding **, long unsigned int)’} [-Wenum-int-mismatch]
  173 | ZEND_API zend_result zend_multibyte_set_script_encoding(const zend_encoding **encoding_list, size_t encoding_list_size)
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/tekimen.linux/src/youkidearitai_php-src/Zend/zend_globals.h:39,
                 from /home/tekimen.linux/src/youkidearitai_php-src/Zend/zend_compile.h:773,
                 from /home/tekimen.linux/src/youkidearitai_php-src/Zend/zend_multibyte.c:21:
/home/tekimen.linux/src/youkidearitai_php-src/Zend/zend_multibyte.h:73:14: note: previous declaration of ‘zend_multibyte_set_script_encoding’ with type ‘int(const zend_encoding **, size_t)’ {aka ‘int(const struct _zend_encoding **, long unsigned int)’}
   73 | ZEND_API int zend_multibyte_set_script_encoding(const zend_encoding **encoding_list, size_t encoding_list_size);
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

…ng’ due to enum/integer mismatch;"

At least, I found warning when GCC 13 on Ubuntu 23.10.
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was probably left out of the fix.

@SakiTakamachi
Copy link
Member

cc: @devnexen

@devnexen devnexen merged commit 5da8335 into php:master Jan 23, 2024
@devnexen
Copy link
Member

Thanks for your keen eye.

@youkidearitai youkidearitai deleted the sig_fix branch January 23, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants