-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Sync headers installation for extensions #13213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've appended also ext/gd here so it's on one place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
This syncs the installed sapi and extension headers on *nix and Windows systems by installing only what is intended outside of php-src. - ext/iconv (without iconv_arginfo.h) - ext/gd: (without gd_arginfo.h and gd_compat.h) - ext/mysqli (mysqli_mysqlnd.h was missing on Windows) - ext/phar (php_phar.h was missing on Windows) - ext/sodium (php_libsodium.h was missing on *nix) - ext/xml (without xml_arginfo.h) - sapi/cli (cli.h was missing on Windows)
I'll combine this PR with #13210 so it's one change altogether in the log... |
This syncs the installed headers on *nix and Windows systems and provides only what is intended to be used outside of php-src.