Skip to content

Sync headers installation for extensions #13213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

petk
Copy link
Member

@petk petk commented Jan 21, 2024

This syncs the installed headers on *nix and Windows systems and provides only what is intended to be used outside of php-src.

  • ext/iconv (without iconv_arginfo.h)
  • ext/gd: (without gd_arginfo.h and gd_compat.h)
  • ext/mysqli (mysqli_mysqlnd.h was missing on Windows)
  • ext/phar (php_phar.h was missing on Windows)
  • ext/sodium (php_libsodium.h was missing on *nix)
  • ext/xml (without xml_arginfo.h)
  • sapi/cli (cli.h was missing on Windows)

@petk
Copy link
Member Author

petk commented Jan 22, 2024

I've appended also ext/gd here so it's on one place.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

This syncs the installed sapi and extension headers on *nix and Windows
systems by installing only what is intended outside of php-src.

- ext/iconv (without iconv_arginfo.h)
- ext/gd: (without gd_arginfo.h and gd_compat.h)
- ext/mysqli (mysqli_mysqlnd.h was missing on Windows)
- ext/phar (php_phar.h was missing on Windows)
- ext/sodium (php_libsodium.h was missing on *nix)
- ext/xml (without xml_arginfo.h)
- sapi/cli (cli.h was missing on Windows)
@petk
Copy link
Member Author

petk commented Jan 26, 2024

I'll combine this PR with #13210 so it's one change altogether in the log...

@petk petk closed this in 52dba99 Jan 28, 2024
@petk petk deleted the patch-headers branch January 28, 2024 18:56
petk added a commit that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants