Fix GH-12504: Corrupted session written when there's a fatal error in autoloader #13207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in autoloader For details and reasoning, see [1] and following. [1] php#12504 (comment)
devnexen
reviewed
Jan 21, 2024
| php_error_docref(NULL, E_WARNING, "Failed to decode session object. Session has been destroyed"); | ||
| return FAILURE; | ||
| } | ||
| zend_try { |
There was a problem hiding this comment.
makes sense (but will be leaving the final say to girgias) but did you measure roughly the before/after change performance impact ?
There was a problem hiding this comment.
In isolation I measured the overhead of doing a sigsetjmp and it was around 7ns on my system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details and reasoning, see [1] and following.
[1] #12504 (comment)