Skip to content

Remove unused internal_functions file #13175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jan 17, 2024

If I'm not mistaken, on Windows the internal_functions.c file is created from the same template internal_functions.c.in as in Autotools build system. This was once used with Microsoft Developer Studio files (1995).

On Windows internal_functions.c file is created from the same template
internal_functions.c.in as in Autotools build system. This was once used
with Microsoft Developer Studio files (1995).
@petk petk requested a review from bukka as a code owner January 17, 2024 07:15
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@Girgias
Copy link
Member

Girgias commented Jan 17, 2024

This file also looks like it wasn't updated, so is probably dead code yes.

@petk petk merged commit 569da8a into php:master Jan 17, 2024
@petk petk deleted the patch-internal-functions-win32 branch January 17, 2024 19:41
@petk
Copy link
Member Author

petk commented Jan 17, 2024

I think so too, yes. Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants