Skip to content

accidentally used print() instead of die() #13158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

divinity76
Copy link
Contributor

No description provided.

@bwoebi
Copy link
Member

bwoebi commented Jan 16, 2024

(Which is actually totally fine, what matters is that there aren't multiple skip: lines / checks, hence the tendendcy to use die(), to skip subsequent checks with multiple checks in SKIPIF.)

@iluuu1994
Copy link
Member

It's probably still better to stay consistent here.

@iluuu1994 iluuu1994 merged commit 6d0a3e8 into php:master Jan 17, 2024
@iluuu1994
Copy link
Member

Thanks @divinity76!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants