Add X509 purpose constant v2 #13149
Closed
Add X509 purpose constant v2 #13149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's get it enabled for any case. Suggested-by: Jakub Zelenka php#6312 (comment)
openssl_arginfo.h should be generated from openssl.stub.php, so drop this commit
X509_PURPOSE_OCSP_HELPER, X509_PURPOSE_TIMESTAMP_SIGN are available from OpenSSL for many years: - X509_PURPOSE_OCSP_HELPER, since 2001 - X509_PURPOSE_TIMESTAMP_SIGN, since 2006
it should be generated from openssl.stub.php
Girgias
reviewed
Jan 15, 2024
Thanks to the previous commit, we get new constants, let's check and enforce them: X509_PURPOSE_OCSP_HELPER, X509_PURPOSE_TIMESTAMP_SIGN
using: ./configure --prefix=/home/vjardin/bin --enable-debug --with-openssl --enable-tokenizer --disable-all --disable-cgi sapi/cli/php build/gen_stub.php -f ext/openssl/openssl.stub.php
vjardin
force-pushed
the
X509_PURPOSEv2
branch
from
8937aa6 to
b4d4bc4
Compare
vjardin
changed the title
kocsismate
approved these changes
Jan 17, 2024
bukka
approved these changes
Jan 18, 2024
|
Merci ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase an old pull request #6312
it is still WIP. It passes all the make test or
sapi/cli/php run-tests.php ext/openssl/tests/*.phpt
TBC: which commits should include openssl_arginfo.h's updates ?