strtok is not comptime #13148
Closed
strtok is not comptime #13148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Jan 14, 2024
| GH-13145: strtok() misoptimization | ||
| --FILE-- | ||
| <?php | ||
| $tok = strtok("This is\tan example\nstring", " \n\t"); |
There was a problem hiding this comment.
shouldn't the strtok function impl. be fixed instead?
There was a problem hiding this comment.
strtok() is stateful, the call cannot be skipped.
nielsdos
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
LGTM, I suspected the same thing when I saw the issue and planned to do the same modification.
shouldn't the strtok function impl. be fixed instead?
Besides the statefulness, I think actually that comptime eval of this would be rare, it's not something that I expect to have constant inputs in normal applications even after constant propagation.
I agree. The fact that this hasn't been reported before makes it pretty evident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-13145