Skip to content

Use true as return types for SplHeap #13147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 14, 2024

No description provided.

@kocsismate
Copy link
Member

So we have given up trying to make these return types void? Or will we have a change to do so when we convert the tentative return types to real ones?

@Girgias
Copy link
Member Author

Girgias commented Jan 15, 2024

So we have given up trying to make these return types void? Or will we have a change to do so when we convert the tentative return types to real ones?

Having true or void is basically the same, and considering the scope of it and how widespread true as a return type is IDK if this wouldn't even require an RFC :|

@Girgias Girgias merged commit f7b498b into php:master Jan 15, 2024
@Girgias Girgias deleted the spl-true-types branch January 15, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants