Explicitly initialize object variables passed to Z_PARAM_OBJ_OF_CLASS_OR_LONG #13146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
Jan 14, 2024
Girgias
approved these changes
Jan 14, 2024
|
I'm not exactly sure about the target branch. For now, master may be reasonable. If there is any issues in older branches then we can backport these fixes. I'm fine to do so now if you think it's a good idea. But anyway, I'm merging my changes for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering whether we should explicitly initialize other similar variables passed to union type ZPP checks in order to prevent compiler miscompilations like the one for
imagefontwidth? E.g. there are quite a fewZ_PARAM_OBJ_OF_CLASS_OR_STRZPP checks where an uninitialized object is passed.