Follow-up fix for GH-13082 #13139
Closed
Follow-up fix for GH-13082 #13139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The font_obj should actually be NULL initialised, not the font gd pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
font_objvariable should actually be NULL initialised, not thefontgd pointer.I missed this in the original code review, but upon adapting a static analyser to find these kinds of issues I found this again.
The reason I missed this is because the variable names are a bit confusing, and they're using C89 style instead of C99 which is confusing because you can't easily see what's used where.
So I merged the declaration and assignment of
fontsuch that it's clear thatfontis always initialised whilefont_objhas to be NULL-initialised.