Skip to content

nitpick re2c "or newer" #13112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2024
Merged

nitpick re2c "or newer" #13112

merged 2 commits into from
Jan 10, 2024

Conversation

divinity76
Copy link
Contributor

just a nitpick,

The old message was

configure: error: re2c 1.0.3 is required to generate PHP lexers.

but re2c 3.0 is also accepted, thus it should be

configure: error: re2c 1.0.3 or newer is required to generate PHP lexers.

@petk
Copy link
Member

petk commented Jan 10, 2024

Thanks, also Bison can be fixed similarly:

--- a/build/php.m4
+++ b/build/php.m4
@@ -1783,7 +1783,7 @@ AC_DEFUN([PHP_PROG_BISON], [
   case $php_bison_check in
     ""|invalid[)]
       if test ! -f "$abs_srcdir/Zend/zend_language_parser.h" || test ! -f "$abs_srcdir/Zend/zend_language_parser.c"; then
-        AC_MSG_ERROR([bison $php_bison_required_version is required to generate PHP parsers (excluded versions: $php_bison_excluded_versions).])
+        AC_MSG_ERROR([bison $php_bison_required_version or newer is required to generate PHP parsers (excluded versions: $php_bison_excluded_versions).])
       fi
 
       YACC="exit 0;"

@divinity76
Copy link
Contributor Author

@petk sounds good! added

@petk petk merged commit 16c1c49 into php:master Jan 10, 2024
@petk
Copy link
Member

petk commented Jan 10, 2024

Thanks @divinity76

@SVGAnimate SVGAnimate mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants