Disable inlining and inter-procedure-analyses for zend_string_equal_val() function that may be overriden for valgrind

[dstogov]

This is a more safely way to fix GH-9068

[nielsdos]

The reason I did not fix it this way is because I was afraid this could negatively impact performance of normal executions, while the issue only happens when people want to debug using Valgrind.

In any case, this solution seems safer and looks correct. I tested and it works. Thanks.

[dstogov]

The reason I did not fix it this way is because I was afraid this could negatively impact performance of normal executions, while the issue only happens when people want to debug using Valgrind.

Yeah, I understood, but the degradation is really small (valgrind shows 0.0004% more instructions on 100 requests to wordpress). Also your solution wasn't complete as it didn't prevent inlining (I saw it with CLANG).

In any case, this solution seems safer and looks correct. I tested and it works. Thanks.

Thanks for taking a look.

[dstogov]

(valgrind shows 0.0004% more instructions on 100 requests to wordpress).

Measuring this with valgrind doesn't make any sense of course, but analysing the call traces, I saw that zend_string_equal_val() was never called from zend_string.h at all.