Skip to content

Add bison -Wall flag to Windows build #13098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add bison -Wall flag to Windows build #13098

merged 1 commit into from
Jan 11, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jan 9, 2024

Following the d7d3a1c, this adds bison flag -Wall also to Windows build system.

Flag has been added via 2127a37.

@petk
Add bison -Wall flag to Windows build
d1510ae 
Following the d7d3a1c, this adds bison
flag -Wall also to Windows build system.

Flag has been added via 2127a37.
@petk petk requested a review from bukka as a code owner January 9, 2024 08:50
devnexen
devnexen approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@petk petk merged commit c774a8d into php:master Jan 11, 2024
@petk petk deleted the patch-bison-wall branch January 11, 2024 10:05
@petk
Copy link
Member Author

petk commented Jan 11, 2024

Added to master branch. Rechecked and all works ok. Thanks for the review @devnexen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen