Skip to content

Fix the SO_LISTENQLEN check in FPM #13089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix the SO_LISTENQLEN check in FPM #13089

merged 1 commit into from
Jan 15, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jan 7, 2024

This fixes the check and defines the HAVE_LQ_SO_LISTENQ. I'm not sure if this was intended here because it might not be fully integrated yet.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the block, seems to me it was just a typo/wrong copy paste

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! looks like some copy and past error maybe.

@petk petk force-pushed the patch-autoconf-fpm branch from 3aebe56 to 6a43aa7 Compare January 14, 2024 21:17
@petk
Copy link
Member Author

petk commented Jan 14, 2024

I've additionally changed the #ifdef check into #elseif defined so the C code reads more logically and has more proper check as the 3rd fallback. Ok, then I'm merging this... I think the NEWS update is not needed here since code works in both cases, now it just has another fallback here.

This now defines the HAVE_LQ_SO_LISTENQ as the fallback check when all
previous have failed in case of FPM LQ. This seemed to be a typo in the
build system.
@petk petk force-pushed the patch-autoconf-fpm branch from 6a43aa7 to 78fdb92 Compare January 14, 2024 22:08
@petk petk merged commit 880ff82 into php:master Jan 15, 2024
@petk petk deleted the patch-autoconf-fpm branch January 15, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants