Skip to content

Remove root library check for dlopen() and dlsym() #13086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

petk
Copy link
Member

@petk petk commented Jan 7, 2024

The root library was added here for the Haiku system, to check dlopen() and dlsym(). However, the root library is already explicitly linked in the system, and it does not need to be checked neither linked anymore, since at least ~2013.

@devnexen if you perhaps remember this. Thanks...

The root library was added here for the Haiku system, to check dlopen()
and dlsym(). However, the root library is already explicitly linked in
the system, and it does not need to be checked neither linked anymore,
since at least ~2013.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@petk petk merged commit 6f3888f into php:master Jan 7, 2024
@petk petk deleted the patch-root branch January 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants