Skip to content

Change PHP_ZTS and PHP_DEBUG to bool to match their ZEND equivalents #13079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Core:
. Added zend_call_stack_get implementation for NetBSD, DragonFlyBSD,
Solaris and Haiku. (David Carlier)
. Enabled ifunc checks on FreeBSD from the 12.x releases. (Freaky)
. Changed the type of PHP_DEBUG and PHP_ZTS constants to bool. (haszi)

Date:
. Added DateTime[Immutable]::createFromTimestamp. (Marc Bennewitz)
Expand Down
3 changes: 3 additions & 0 deletions UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ PHP 8.4 UPGRADE NOTES
1. Backward Incompatible Changes
========================================

- Core:
. The type of PHP_DEBUG and PHP_ZTS constants changed to bool.

- DOM:
. New methods and constants were added to some DOM classes. If you inherit
from these and you happen to have a method or property with the same name,
Expand Down
2 changes: 1 addition & 1 deletion ext/zip/tests/bug72660.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Bug #72660 (NULL Pointer dereference in zend_virtual_cwd)
zip
--SKIPIF--
<?php
if(PHP_ZTS == 0) { die('skip ZTS required'); }
if(!PHP_ZTS) { die('skip ZTS required'); }
?>
--FILE--
<?php
Expand Down
4 changes: 2 additions & 2 deletions main/main.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@
*/
const PHP_VERSION_ID = UNKNOWN;
/**
* @var int
* @var bool
* @cvalue PHP_ZTS
*/
const PHP_ZTS = UNKNOWN;
/**
* @var int
* @var bool
* @cvalue PHP_DEBUG
*/
const PHP_DEBUG = UNKNOWN;
Expand Down
6 changes: 3 additions & 3 deletions main/main_arginfo.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.