Skip to content

Remove unused phpdbg build variables #13078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

petk
Copy link
Member

@petk petk commented Jan 5, 2024

  • PHP_PHPDBG_CFLAGS and PHP_PHPDBG_FILES were once used in the generated Makefile.
  • BUILD_PHPDBG check was used together with unused and obsolete phpdbg webhelper configuration.

- PHP_PHPDBG_CFLAGS and PHP_PHPDBG_FILES were once used in the generated
  Makefile.
- BUILD_PHPDBG check was used together with unused and obsolete phpdbg
  webhelper configuration.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petk petk merged commit 2fec3e7 into php:master Jan 6, 2024
@petk petk deleted the patch-sapi-phpdbg branch January 6, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants