Skip to content

Remove unused SIZEOF_SHORT #13034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Remove unused SIZEOF_SHORT #13034

merged 1 commit into from
Dec 29, 2023

Conversation

petk
Copy link
Member

@petk petk commented Dec 27, 2023

The AC_CHECK_SIZEOF macro defines the SIZEOF_SHORT constant (size 2 on 32 and 64bit platforms) which is unused in the current code.

@petk petk merged commit 84022db into php:master Dec 29, 2023
@petk petk deleted the patch-sizeof-short branch December 29, 2023 23:58
@petk
Copy link
Member Author

petk commented Dec 30, 2023

Thanks for the reviews. I'll add updates to UPGRADING docs in the near future regarding all these recent changes that concern main/php_config.h constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants