Fix GH-12974: Apache crashes on shutdown when using pg_pconnect() #13032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ZTS, the global variables are stored in dynamically allocated memory. When the module gets shut down this memory is released. After the module is shut down, only then are the persistent resources cleared. Normally this isn't an issue, but pgsql and odbc refer to the globals to modify some counters, after the globals have been freed. Fix this by guarding the modification.
|
Looking good ; I noticed oci8 seems to have a similar issue (php_oci_pconnection_list_dtor), up to you if yo wanna update in this PR. |
|
Updated. (also fixed a syntax mistake in NTS, oops) |
|
Actually looks like oci8 is a little bit more difficult because it accesses the globals in functions that are transitively called too... And also in macros (e.g. PHP_OCI_CALL) Not too sure what clean way to fix it there. |
|
gotcha, preferably it would be nice to have odbc/pgsql fixd for the next release, we can always come back to oci8 later if it takes time. |
I agree, dropped oci8 change. |
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ZTS, the global variables are stored in dynamically allocated memory. When the module gets shut down this memory is released. After the module is shut down, only then are the persistent resources cleared. Normally this isn't an issue, but pgsql and odbc refer to the globals to modify some counters, after the globals have been freed.
Fix this by guarding the modification.
We don't have Apache tests unfortunately, but I tested this manually with Valgrind (instructions in the linked issue).