Support index.php fallback for files in built-in server #12992
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Dec 21, 2023
|
@iluuu1994, at a glance, I think this removes support for |
|
@asmecher I'm not sure what you are referencing. Can you clarify? |
|
@iluuu1994 My apologies -- I've just checked and |
Girgias
reviewed
Dec 23, 2023
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jan 8, 2024
If no router script is used, the built-in webserver will now look for a fallback index file recursively in all cases, including URLs with a period. Fixes phpGH-12604 Closes phpGH-12992
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jan 8, 2024
If no router script is used, the built-in webserver will now look for a fallback index file recursively in all cases, including URLs with a period. Fixes phpGH-12604 Closes phpGH-12992
If no router script is used, the built-in webserver will now look for a fallback index file recursively in all cases, including URLs with a period. Fixes phpGH-12604 Closes phpGH-12992
|
Much appreciated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no router script is used, the built-in webserver will now look for a fallback index file recursively in all cases, including URLs with a period.
Furthermore, if a router script returns false, we will no longer perform a recursive fallback. Previously, recursive fallback was performed when the URL contained no period. The rationale for this is that it avoids serving the root index.php file when the router has indicated that the file is a static file.
The existing behavior essentially assumes that virtual routes don't contain periods, and that real files do. Both of those assumptions are incorrect.
Fixes GH-12604